Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22950 )
Change subject: IMPALA-13986: Update JS scripts to align with linting rules ...................................................................... Patch Set 9: (15 comments) The additional code-analysis comments are still being generated from the following. 1. The library methods declared are not used(as they are used in .tmpl not .js) 2. The additional optional parameters declared for a method(helpful for future implementation/readability) So, these comments do not need to be fixed. All the JS scripts have now been aligned with the linting rules. http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/common_util.js File www/scripts/common_util.js: http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/common_util.js@80 PS8, Line 80: function renderSize(data, type, row) { > 'renderSize' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/common_util.js@80 PS8, Line 80: function renderSize(data, type, row) { > 'row' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/common_util.js@93 PS8, Line 93: function renderTime(data, type, row) { > 'renderTime' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/common_util.js@93 PS8, Line 93: function renderTime(data, type, row) { > 'row' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/common_util.js@106 PS8, Line 106: function getQueryID() { > 'getQueryID' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/fragment_diagram.js@664 PS8, Line 664: export function setTimingDiagramDimensions(ignored_arg) { > 'ignored_arg' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/fragment_diagram.js@700 PS8, Line 700: fragment_diagram.addEventListener("mouseout", e => { > 'e' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/fragment_metrics_diagram.js File www/scripts/query_timeline/fragment_metrics_diagram.js: http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/fragment_metrics_diagram.js@99 PS8, Line 99: value : (value, ratio, id, index) => { > 'index' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/fragment_metrics_diagram.js@106 PS8, Line 106: title : (x, index) => x.toFixed(decimals) > 'index' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/fragment_metrics_diagram.js@297 PS8, Line 297: function dragResizeBarBegin(mousedown_e) { > 'mousedown_e' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/global_dom.js File www/scripts/query_timeline/global_dom.js: http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/global_dom.js@20 PS8, Line 20: const fs = await import("fs"); > Parsing error: Cannot use keyword 'await' outside an async function The testing framework that uses nodejs does not restrict the await keyword in root. http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/host_utilization_diagram.js File www/scripts/query_timeline/host_utilization_diagram.js: http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/host_utilization_diagram.js@122 PS8, Line 122: value : (value, ratio, id, index) => { > 'index' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/host_utilization_diagram.js@129 PS8, Line 129: title : (x, index) => x.toFixed(decimals) + "s" > 'index' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/host_utilization_diagram.js@315 PS8, Line 315: function dragResizeBarBegin(mousedown_e) { > 'mousedown_e' is defined but never used. Done http://gerrit.cloudera.org:8080/#/c/22950/8/www/scripts/query_timeline/host_utilization_diagram.js@325 PS8, Line 325: host_utilization_close_btn.addEventListener("click", e => { > 'e' is defined but never used. Done -- To view, visit http://gerrit.cloudera.org:8080/22950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c8851c3d2f4e95b7eebd61f379361818afca7ea Gerrit-Change-Number: 22950 Gerrit-PatchSet: 9 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 28 May 2025 17:26:37 +0000 Gerrit-HasComments: Yes
