Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/22049 )
Change subject: IMPALA-10319: Support arbitrary encodings on Text files ...................................................................... Patch Set 25: (4 comments) http://gerrit.cloudera.org:8080/#/c/22049/21/tests/query_test/test_charcodec.py File tests/query_test/test_charcodec.py: http://gerrit.cloudera.org:8080/#/c/22049/21/tests/query_test/test_charcodec.py@72 PS21, Line 72: class TestCharCodecGen(ImpalaTestSuite): > I would be surprised if files sizes would really matter for Impala (maybe f There's a couple tests that take a bit longer, but not one really stands out. We can move them to exhaustive mode, but I've tried it now and the non-exhaustive is only 2,5 min, which seems a reasonable time. Previous 4 min results were either my mistake, or my machine was slowed down for some reason. http://gerrit.cloudera.org:8080/#/c/22049/23/tests/query_test/test_charcodec.py File tests/query_test/test_charcodec.py: http://gerrit.cloudera.org:8080/#/c/22049/23/tests/query_test/test_charcodec.py@379 PS23, Line 379: > There are some Impala test environments where Hive is not available (e.g. s Ok, I removed these from where Hive is not involved. http://gerrit.cloudera.org:8080/#/c/22049/23/tests/query_test/test_charcodec.py@432 PS23, Line 432: self.execute_query( : """insert overwrite {}.{} select * from {}.{}""" : .format(db, encoded_table, db, utf8_table)) : > The ordering comes after decoding. Ack http://gerrit.cloudera.org:8080/#/c/22049/24/tests/query_test/test_charcodec.py File tests/query_test/test_charcodec.py: http://gerrit.cloudera.org:8080/#/c/22049/24/tests/query_test/test_charcodec.py@426 PS24, Line 426: > nit: extra whitespace Ack -- To view, visit http://gerrit.cloudera.org:8080/22049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I787cd01caa52a19d6645519a6cedabe0a5253a65 Gerrit-Change-Number: 22049 Gerrit-PatchSet: 25 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 30 May 2025 11:17:44 +0000 Gerrit-HasComments: Yes
