Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 )
Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/10471/3/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/10471/3/common/thrift/JniCatalog.thrift@55 PS3, Line 55: COMMENT_ON need comma http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/main/cup/sql-parser.cup@1030 PS3, Line 1030: {: Can you add a short comment as to why USER cannot be a keyword? http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/main/java/org/apache/impala/analysis/OwnerType.java File fe/src/main/java/org/apache/impala/analysis/OwnerType.java: http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/main/java/org/apache/impala/analysis/OwnerType.java@23 PS3, Line 23: public class OwnerType { nit: Can the name be changed since it's not just type but includes the name? e.g. just Owner or OwnerContext http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3757 PS3, Line 3757: ParserError("ALTER DATABASE SET OWNER ROLE foo"); Add test for no parms after OWNER. e.g. ALTER DATABASE db SET OWNER -- To view, visit http://gerrit.cloudera.org:8080/10471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3b923021ebce5192d2d64784e7ddb952ba82bc3 Gerrit-Change-Number: 10471 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Jun 2018 21:30:46 +0000 Gerrit-HasComments: Yes
