Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 40: (9 comments) http://gerrit.cloudera.org:8080/#/c/22424/37/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22424/37/shell/impala_shell.py@1888 PS37, Line 1888: > Done Done http://gerrit.cloudera.org:8080/#/c/22424/37/shell/impala_shell.py@1889 PS37, Line 1889: > Done Done http://gerrit.cloudera.org:8080/#/c/22424/37/shell/impala_shell.py@1891 PS37, Line 1891: > Done Done http://gerrit.cloudera.org:8080/#/c/22424/37/shell/impala_shell.py@1919 PS37, Line 1919: > Done Done http://gerrit.cloudera.org:8080/#/c/22424/37/shell/impala_shell.py@1920 PS37, Line 1920: > This is a refresh token feature. Its covered in another jira. Ack http://gerrit.cloudera.org:8080/#/c/22424/40/shell/impala_shell/option_parser.py File shell/impala_shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/22424/40/shell/impala_shell/option_parser.py@378 PS40, Line 378: help=SUPPRESS_HELP) Was this added by accident? Doesn't seem like it should be here. http://gerrit.cloudera.org:8080/#/c/22424/37/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22424/37/tests/custom_cluster/test_shell_jwt_auth.py@206 PS37, Line 206: def __assert_success_fail_metric(self, success_count=0, fail_count=0): > Should these new OAuth tests go in the test_shell_oauth_auth.py file? Done http://gerrit.cloudera.org:8080/#/c/22424/37/tests/custom_cluster/test_shell_jwt_auth.py@276 PS37, Line 276: > Done Done http://gerrit.cloudera.org:8080/#/c/22424/40/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22424/40/tests/custom_cluster/test_shell_jwt_auth.py@57 PS40, Line 57: Need to remove these OAUTH defs since the tests were moved to test_shell_oauth_auth.py -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 40 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Wed, 04 Jun 2025 19:35:56 +0000 Gerrit-HasComments: Yes
