Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22986 )
Change subject: IMPALA-14083: Connected user and session user mismatch when cookie based authentication is used with SPNEGO ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/22986/1/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java File fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java: http://gerrit.cloudera.org:8080/#/c/22986/1/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@182 PS1, Line 182: intersting nit: interesting http://gerrit.cloudera.org:8080/#/c/22986/1/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@206 PS1, Line 206: assertEquals(ret, 0); // cluster should start up should be assertEquals(0, ret) since the assertEquals function's first parameter is the expected value and the second parameter is the actual value. http://gerrit.cloudera.org:8080/#/c/22986/1/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@222 PS1, Line 222: assertEquals(openResp.getStatus().getStatusCode(), TStatusCode.ERROR_STATUS); should be assertEquals(TStatusCode.ERROR_STATUS, openResp.getStatus().getStatusCode()); http://gerrit.cloudera.org:8080/#/c/22986/1/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@238 PS1, Line 238: assertEquals(openResp.getStatus().getStatusCode(), TStatusCode.SUCCESS_STATUS); should be assertEquals(TStatusCode.SUCCESS_STATUS, openResp.getStatus().getStatusCode()); http://gerrit.cloudera.org:8080/#/c/22986/1/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@250 PS1, Line 250: } even though it *shouldn't* happen, please consider adding an else here to fail the test faster: } else { fail("no cookies returned from Impala"); } http://gerrit.cloudera.org:8080/#/c/22986/1/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@319 PS1, Line 319: assertEquals(exitCode, 0); Should be assertEquals(0, exitCode) -- To view, visit http://gerrit.cloudera.org:8080/22986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7223e449c32484bfd2295f7a9e728b7c02637e9 Gerrit-Change-Number: 22986 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Fri, 06 Jun 2025 15:41:26 +0000 Gerrit-HasComments: Yes
