Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23005
Change subject: [PROTOTYPE] Modify FrontendFixture to support the Calcite compiler factory ...................................................................... [PROTOTYPE] Modify FrontendFixture to support the Calcite compiler factory This updates FrontendFixture to use the CompilerFactory to run queries. It maintains two separate CompilerFactory instances. One is the compilerUnderTest which is either the original compiler or Calcite. The other is always the original compiler, which is necessary for handling DDLs in the test infrastructure (e.g. creating tables and views). This should make it easier to run additional frontend tests with Calcite. Since tests often want to create a parsed statement without a TQueryCtx, this adds signatures for createParsedStatement(). These extra signatures are shared between CompilerFactory implementations, so it adds an AbstractCompilerFactory that implements the extra signatures. CompilerFactoryImpl and CalciteCompilerFactory now extend AbstractCompilerFactory. CalciteParsedStatement is reworked to get the session database from the StmtMetadataLoader rather than stashing the table list itself. Testing: - Ran core tests Change-Id: Ia7c83f9b8f1ab5885bda86cb9a1b3510f0ea05c4 --- M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java A fe/src/main/java/org/apache/impala/service/AbstractCompilerFactory.java M fe/src/main/java/org/apache/impala/service/CompilerFactory.java M fe/src/main/java/org/apache/impala/service/CompilerFactoryImpl.java M fe/src/test/java/org/apache/impala/common/FrontendFixture.java M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java 9 files changed, 193 insertions(+), 41 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/23005/1 -- To view, visit http://gerrit.cloudera.org:8080/23005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7c83f9b8f1ab5885bda86cb9a1b3510f0ea05c4 Gerrit-Change-Number: 23005 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]>
