Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22924 )
Change subject: IMPALA-13235: Update the build toolchain to include the latest OpenTelemetry C++ sdk. ...................................................................... Patch Set 13: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22924/13/be/src/observe/otel-flags.cc File be/src/observe/otel-flags.cc: http://gerrit.cloudera.org:8080/#/c/22924/13/be/src/observe/otel-flags.cc@208 PS13, Line 208: LOG(ERROR) << "Flag '" << flagname << "' contains an invalid header (missing '='): " line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22924/13/be/src/observe/otel.cc File be/src/observe/otel.cc: http://gerrit.cloudera.org:8080/#/c/22924/13/be/src/observe/otel.cc@102 PS13, Line 102: chrono::duration<float>(FLAGS_otel_retry_policy_initial_backoff_s); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22924/13/be/src/observe/otel.cc@138 PS13, Line 138: FLAGS_tls_ciphersuites : FLAGS_otel_tls_cipher_suites; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22924/13/be/src/observe/otel.cc@153 PS13, Line 153: unique_ptr<SpanExporter> exporter = unique_ptr<SpanExporter>(new OtlpHttpExporter(opts)); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie40b5cd33274df13f3005bf7a704299ebfff8a5b Gerrit-Change-Number: 22924 Gerrit-PatchSet: 13 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 12 Jun 2025 19:10:54 +0000 Gerrit-HasComments: Yes
