Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10550 )
Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans ...................................................................... Patch Set 11: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10550/11/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/10550/11/be/src/exec/hdfs-scan-node.cc@186 PS11, Line 186: AVERAGE_SCANNER_THREAD_CONCURRENCY, &active_scanner_thread_counter_); would it be better to move this above line 183 so that other code doesn't have to consider it being null after the Open phase? Maybe that doesn't actually simplify things since prepare might have failed... So, why doesn't this get set in Prepare? Oh, I guess the active counter isn't initialized until Open in the base. Is there a reason why those aren't initialized in prepare? (Not asking for that to change now.) -- To view, visit http://gerrit.cloudera.org:8080/10550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebd2600b4784fd19696c9b92eefb7d7e9db0c80b Gerrit-Change-Number: 10550 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 06 Jun 2018 16:08:35 +0000 Gerrit-HasComments: Yes
