Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22870 )
Change subject: IMPALA-14061: Calcite Planner: added Calcite rules ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/22870/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/22870/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@387 PS8, Line 387: 100 > Can you still refer to max_cnf_exprs query option here, but cap it to 100 f That's an interesting idea worth exploring! I can go ahead and do this, but it's a little awkward that the default of 200 is essentially ignored. My only other worry really is this: Was the value set at 200 as a high water mark or a low water mark? Or just a guess? Because if customers only raise the value, it doesn't make too much sense. And also: Does it make sense to cap? While 200 really causes problems with tpcds queries, I can't say for sure that it is an issue on all queries. Also, I should probably put extra comments by the option specifying what is going on for Calcite, right? -- To view, visit http://gerrit.cloudera.org:8080/22870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6671f7ed298a18965ef0b7a5fc10f4912333a52b Gerrit-Change-Number: 22870 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 17 Jun 2025 16:38:08 +0000 Gerrit-HasComments: Yes
