Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22995 )
Change subject: IMPALA-14123: Allow forcing predicate push down to Iceberg ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/22995/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22995/2//COMMIT_MSG@25 PS2, Line 25: footers > nit: footers/file metadata Done http://gerrit.cloudera.org:8080/#/c/22995/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/22995/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@181 PS2, Line 181: initPushDownHint(); : extractIcebergConjuncts(); : snapshotId_ = IcebergUtil.getSnapshotId(getIceTable(), tblRef_.getTimeTravelSpec()); : } : : public PlanNode createIcebergScanPlan() throws ImpalaException { : PlanNode res = createPlanNodeHelper(); : P > nit: this could be moved to its own method Done http://gerrit.cloudera.org:8080/#/c/22995/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@945 PS2, Line 945: .getDefa > nit: Compound Done http://gerrit.cloudera.org:8080/#/c/22995/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@943 PS2, Line 943: IcebergUtil.getPartitionTransformType( : iceCol, : getIceTable().getDefaultPartitionSpec()); : if (pred.test > Not sure what is the best semantics here, but we should treat partitions/hi agree, I think that it is ok like this -- To view, visit http://gerrit.cloudera.org:8080/22995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8eb4ab5204c20b3991fdf305d7317f4023904a0f Gerrit-Change-Number: 22995 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 20 Jun 2025 19:11:16 +0000 Gerrit-HasComments: Yes
