Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22527 )
Change subject: IMPALA-13820: add ipv6 support for webui/hs2/hs2-http/beeswax ...................................................................... Patch Set 32: (5 comments) http://gerrit.cloudera.org:8080/#/c/22527/32/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/22527/32/tests/beeswax/impala_beeswax.py@122 PS32, Line 122: 21000 nit: Use DEFAULT_BEESWAX_PORT from common/impala_cluster.py http://gerrit.cloudera.org:8080/#/c/22527/32/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/22527/32/tests/common/impala_service.py@270 PS32, Line 270: webserver_port=25000, beeswax_port=21000, krpc_port=27000, hs2_port=21050, : hs2_http_port=28000 nit: Use constants from common/impala_cluster.py? http://gerrit.cloudera.org:8080/#/c/22527/32/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22527/32/tests/common/impala_test_suite.py@270 PS32, Line 270: 1st impalad 1st impalad or None if nothing is started. http://gerrit.cloudera.org:8080/#/c/22527/32/tests/common/impala_test_suite.py@1800 PS32, Line 1800: expected_count=3 Is this necessary? check_connections() never called with different parameter. http://gerrit.cloudera.org:8080/#/c/22527/32/tests/metadata/test_event_processing_base.py File tests/metadata/test_event_processing_base.py: http://gerrit.cloudera.org:8080/#/c/22527/32/tests/metadata/test_event_processing_base.py@34 PS32, Line 34: def _run_test_insert_events_impl(cls, suite, unique_database, is_transactional=False): Please file a follow up JIRA to clean this up based on our prior discussion https://gerrit.cloudera.org/c/22527/23/tests/metadata/test_event_processing_base.py#34 -- To view, visit http://gerrit.cloudera.org:8080/22527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ac66c568cc9bb06f4a3915db07a53c100109b6 Gerrit-Change-Number: 22527 Gerrit-PatchSet: 32 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Fri, 20 Jun 2025 20:12:20 +0000 Gerrit-HasComments: Yes
