Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23068 )
Change subject: IMPALA-13474: Support aggregated profile for webUI's query timeline ...................................................................... Patch Set 1: (16 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_diagram.js@208 PS1, Line 208: for (let i = LAST_E_INDEX; i >= 0; --i) { 'i' is already declared in the upper scope on line 200 column 7. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_diagram.js@219 PS1, Line 219: dy = (ts_stat.count[j] / inst_count) * BAR_HEIGHT; Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_diagram.js@451 PS1, Line 451: export function collectFragmentEventsFromProfile() { Expected to return a value at the end of function 'collectFragmentEventsFromProfile'. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_diagram.js@464 PS1, Line 464: if (legacy_profile || execution_profile.child_profiles[2].event_sequences === undefined) { This line has a length of 94. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_diagram.js@554 PS1, Line 554: } Missing semicolon. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_diagram.js@593 PS1, Line 593: export function setTimingDiagramDimensions(ignored_arg) { 'ignored_arg' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_diagram.js@633 PS1, Line 633: fragment_diagram.addEventListener("mouseout", e => { 'e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_diagram.js@877 PS1, Line 877: DrawBars_legacy(fragment_svg_group, rownum_l, ROW_HEIGHT, fevents, name_width, PX_PER_NS); This line has a length of 96. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_diagram.js@884 PS1, Line 884: DrawBars_legacy(fragment_svg_group, rownum_l, ROW_HEIGHT, node.events, name_width, This line has a length of 92. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_metrics_diagram.js File www/scripts/query_timeline/fragment_metrics_diagram.js: http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_metrics_diagram.js@99 PS1, Line 99: value : (value, ratio, id, index) => { 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_metrics_diagram.js@106 PS1, Line 106: title : (x, index) => x.toFixed(decimals) 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/fragment_metrics_diagram.js@297 PS1, Line 297: function dragResizeBarBegin(mousedown_e) { 'mousedown_e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/host_utilization_diagram.js File www/scripts/query_timeline/host_utilization_diagram.js: http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/host_utilization_diagram.js@122 PS1, Line 122: value : (value, ratio, id, index) => { 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/host_utilization_diagram.js@129 PS1, Line 129: title : (x, index) => x.toFixed(decimals) + "s" 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/host_utilization_diagram.js@315 PS1, Line 315: function dragResizeBarBegin(mousedown_e) { 'mousedown_e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/1/www/scripts/query_timeline/host_utilization_diagram.js@325 PS1, Line 325: host_utilization_close_btn.addEventListener("click", e => { 'e' is defined but never used. -- To view, visit http://gerrit.cloudera.org:8080/23068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f59bc8ab6bee91bd5fa446a207891453600b3e Gerrit-Change-Number: 23068 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Jun 2025 11:20:42 +0000 Gerrit-HasComments: Yes
