Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23071 )
Change subject: IMPALA-13985: Rename webUI's JS Tests to better fit general test naming schemes ...................................................................... Patch Set 2: (1 comment) Thank you for the comments http://gerrit.cloudera.org:8080/#/c/23071/1/tests/webui/js_tests/query_timeline/fragment_diagram.test.js File tests/webui/js_tests/query_timeline/fragment_diagram.test.js: http://gerrit.cloudera.org:8080/#/c/23071/1/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@56 PS1, Line 56: Basic Case (SvgGroup) > Lets be consistent by not using whitespace and parenthesis in test name. It may not look proper to remove all whitespaces and replace them with _, "." and "-"., especially in the case of chart commons and other test names. But, if still that's preferred, I will make sure to rename it. -- To view, visit http://gerrit.cloudera.org:8080/23071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5715d47cef5c1c3c06b4f2de7fe467aee3de8868 Gerrit-Change-Number: 23071 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 23 Jun 2025 16:51:03 +0000 Gerrit-HasComments: Yes
