Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23082 )
Change subject: IMPALA-14141 (Addendum): Restore Hive compactor settings after HIVE-28662 ...................................................................... Patch Set 2: (1 comment) I have addressed Csaba's comment on patch set 1. Let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/23082/1/fe/src/test/resources/hive-site.xml.py File fe/src/test/resources/hive-site.xml.py: http://gerrit.cloudera.org:8080/#/c/23082/1/fe/src/test/resources/hive-site.xml.py@96 PS1, Line 96: 'hive.metastore.housekeeping.threads.on': 'true', > hive.metastore.housekeeping.threads.on is also set here - we should avoid o Thanks for pointing this out Csaba! I will revise the patch so that we set this configuration to false only if VARIANT is not 'housekeeping_on'. -- To view, visit http://gerrit.cloudera.org:8080/23082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd651aeacf3deba1a8272803207192d5da32a2e4 Gerrit-Change-Number: 23082 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 24 Jun 2025 09:10:42 +0000 Gerrit-HasComments: Yes
