Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala ...................................................................... Patch Set 35: (110 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@33 PS35, Line 33: protected BitSet abortedBits; // BitSet for flagging aborted write ids. Bit is true if aborted, false if open line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@45 PS35, Line 45: public ValidReaderWriteIdList(String tableName, long[] exceptions, BitSet abortedBits, long highWatermark) { line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@49 PS35, Line 49: long[] exceptions, BitSet abortedBits, long highWatermark, long minOpenWriteId) { line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java@255 PS35, Line 255: return new ValidReaderWriteIdList(tableName, exceptions, abortedBits, value, minOpenWriteId); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@25 PS35, Line 25: * An implementation to store and manage list of ValidWriteIds for each tables read by current line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@67 PS35, Line 67: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>... line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@85 PS35, Line 85: // Format <txnId>$<table_name>:<hwm>:<minOpenWriteId>:<open_writeids>:<abort_writeids>$<table_name>... line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidTxnWriteIdList.java@90 PS35, Line 90: for (HashMap.Entry<String, ValidWriteIdList> entry : tablesValidWriteIdList.entrySet()) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@41 PS35, Line 41: * Indicates whether a given write ID is valid. Note that valid may have different meanings line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@42 PS35, Line 42: * for different implementations, as some will only want to see committed transactions and some line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@50 PS35, Line 50: * Returns {@code true} if such base file can be used to materialize the snapshot represented by line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@58 PS35, Line 58: * Find out if a range of write ids are valid. Note that valid may have different meanings line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@59 PS35, Line 59: * for different implementations, as some will only want to see committed transactions and some line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@83 PS35, Line 83: * @return table name (<db_name>.<table_name>) associated with ValidWriteIdList. line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@94 PS35, Line 94: * Get the list of write ids under the high water mark that are not valid. Note that invalid line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/common/ValidWriteIdList.java@95 PS35, Line 95: * may have different meanings for different implementations, as some will only want to see open line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@38 PS35, Line 38: @org.apache.hadoop.classification.InterfaceAudience.Public @org.apache.hadoop.classification.InterfaceStability.Stable public class TableValidWriteIds implements org.apache.thrift.TBase<TableValidWriteIds, TableValidWriteIds._Fields>, java.io.Serializable, Cloneable, Comparable<TableValidWriteIds> { line too long (300 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@39 PS35, Line 39: private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new org.apache.thrift.protocol.TStruct("TableValidWriteIds"); line too long (133 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@41 PS35, Line 41: private static final org.apache.thrift.protocol.TField FULL_TABLE_NAME_FIELD_DESC = new org.apache.thrift.protocol.TField("fullTableName", org.apache.thrift.protocol.TType.STRING, (short)1); line too long (192 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@42 PS35, Line 42: private static final org.apache.thrift.protocol.TField WRITE_ID_HIGH_WATER_MARK_FIELD_DESC = new org.apache.thrift.protocol.TField("writeIdHighWaterMark", org.apache.thrift.protocol.TType.I64, (short)2); line too long (205 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@43 PS35, Line 43: private static final org.apache.thrift.protocol.TField INVALID_WRITE_IDS_FIELD_DESC = new org.apache.thrift.protocol.TField("invalidWriteIds", org.apache.thrift.protocol.TType.LIST, (short)3); line too long (194 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@44 PS35, Line 44: private static final org.apache.thrift.protocol.TField MIN_OPEN_WRITE_ID_FIELD_DESC = new org.apache.thrift.protocol.TField("minOpenWriteId", org.apache.thrift.protocol.TType.I64, (short)4); line too long (192 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@45 PS35, Line 45: private static final org.apache.thrift.protocol.TField ABORTED_BITS_FIELD_DESC = new org.apache.thrift.protocol.TField("abortedBits", org.apache.thrift.protocol.TType.STRING, (short)5); line too long (187 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@47 PS35, Line 47: private static final Map<Class<? extends IScheme>, SchemeFactory> schemes = new HashMap<Class<? extends IScheme>, SchemeFactory>(); line too long (133 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@59 PS35, Line 59: /** The set of fields this struct contains, along with convenience methods for finding and manipulating them. */ line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@101 PS35, Line 101: if (fields == null) throw new IllegalArgumentException("Field " + fieldId + " doesn't exist!"); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@136 PS35, Line 136: Map<_Fields, org.apache.thrift.meta_data.FieldMetaData> tmpMap = new EnumMap<_Fields, org.apache.thrift.meta_data.FieldMetaData>(_Fields.class); line too long (148 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137 PS35, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@137 PS35, Line 137: tmpMap.put(_Fields.FULL_TABLE_NAME, new org.apache.thrift.meta_data.FieldMetaData("fullTableName", org.apache.thrift.TFieldRequirementType.REQUIRED, line too long (153 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@138 PS35, Line 138: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING))); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139 PS35, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@139 PS35, Line 139: tmpMap.put(_Fields.WRITE_ID_HIGH_WATER_MARK, new org.apache.thrift.meta_data.FieldMetaData("writeIdHighWaterMark", org.apache.thrift.TFieldRequirementType.REQUIRED, line too long (169 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@140 PS35, Line 140: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141 PS35, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@141 PS35, Line 141: tmpMap.put(_Fields.INVALID_WRITE_IDS, new org.apache.thrift.meta_data.FieldMetaData("invalidWriteIds", org.apache.thrift.TFieldRequirementType.REQUIRED, line too long (157 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142 PS35, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@142 PS35, Line 142: new org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@143 PS35, Line 143: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64)))); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144 PS35, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@144 PS35, Line 144: tmpMap.put(_Fields.MIN_OPEN_WRITE_ID, new org.apache.thrift.meta_data.FieldMetaData("minOpenWriteId", org.apache.thrift.TFieldRequirementType.OPTIONAL, line too long (156 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@145 PS35, Line 145: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.I64))); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146 PS35, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@146 PS35, Line 146: tmpMap.put(_Fields.ABORTED_BITS, new org.apache.thrift.meta_data.FieldMetaData("abortedBits", org.apache.thrift.TFieldRequirementType.REQUIRED, line too long (148 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@147 PS35, Line 147: new org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRING , true))); line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@149 PS35, Line 149: org.apache.thrift.meta_data.FieldMetaData.addStructMetaDataMap(TableValidWriteIds.class, metaDataMap); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@215 PS35, Line 215: /** Returns true if field fullTableName is set (has been assigned a value) and false otherwise */ line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@236 PS35, Line 236: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@239 PS35, Line 239: /** Returns true if field writeIdHighWaterMark is set (has been assigned a value) and false otherwise */ line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@245 PS35, Line 245: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __WRITEIDHIGHWATERMARK_ISSET_ID, value); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@275 PS35, Line 275: /** Returns true if field invalidWriteIds is set (has been assigned a value) and false otherwise */ line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@296 PS35, Line 296: __isset_bitfield = EncodingUtils.clearBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@299 PS35, Line 299: /** Returns true if field minOpenWriteId is set (has been assigned a value) and false otherwise */ line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@305 PS35, Line 305: __isset_bitfield = EncodingUtils.setBit(__isset_bitfield, __MINOPENWRITEID_ISSET_ID, value); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@318 PS35, Line 318: this.abortedBits = abortedBits == null ? (ByteBuffer)null : ByteBuffer.wrap(Arrays.copyOf(abortedBits, abortedBits.length)); line too long (128 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@329 PS35, Line 329: /** Returns true if field abortedBits is set (has been assigned a value) and false otherwise */ line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@406 PS35, Line 406: /** Returns true if field corresponding to fieldID is set (has been assigned a value) and false otherwise */ line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@528 PS35, Line 528: lastComparison = Boolean.valueOf(isSetFullTableName()).compareTo(other.isSetFullTableName()); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@533 PS35, Line 533: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.fullTableName, other.fullTableName); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@538 PS35, Line 538: lastComparison = Boolean.valueOf(isSetWriteIdHighWaterMark()).compareTo(other.isSetWriteIdHighWaterMark()); line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@543 PS35, Line 543: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.writeIdHighWaterMark, other.writeIdHighWaterMark); line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@548 PS35, Line 548: lastComparison = Boolean.valueOf(isSetInvalidWriteIds()).compareTo(other.isSetInvalidWriteIds()); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@553 PS35, Line 553: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.invalidWriteIds, other.invalidWriteIds); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@558 PS35, Line 558: lastComparison = Boolean.valueOf(isSetMinOpenWriteId()).compareTo(other.isSetMinOpenWriteId()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@563 PS35, Line 563: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.minOpenWriteId, other.minOpenWriteId); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@568 PS35, Line 568: lastComparison = Boolean.valueOf(isSetAbortedBits()).compareTo(other.isSetAbortedBits()); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@573 PS35, Line 573: lastComparison = org.apache.thrift.TBaseHelper.compareTo(this.abortedBits, other.abortedBits); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@585 PS35, Line 585: public void read(org.apache.thrift.protocol.TProtocol iprot) throws org.apache.thrift.TException { line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@589 PS35, Line 589: public void write(org.apache.thrift.protocol.TProtocol oprot) throws org.apache.thrift.TException { line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@638 PS35, Line 638: throw new org.apache.thrift.protocol.TProtocolException("Required field 'fullTableName' is unset! Struct:" + toString()); line too long (127 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@642 PS35, Line 642: throw new org.apache.thrift.protocol.TProtocolException("Required field 'writeIdHighWaterMark' is unset! Struct:" + toString()); line too long (134 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@646 PS35, Line 646: throw new org.apache.thrift.protocol.TProtocolException("Required field 'invalidWriteIds' is unset! Struct:" + toString()); line too long (129 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@650 PS35, Line 650: throw new org.apache.thrift.protocol.TProtocolException("Required field 'abortedBits' is unset! Struct:" + toString()); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@658 PS35, Line 658: write(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(out))); line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@664 PS35, Line 664: private void readObject(java.io.ObjectInputStream in) throws java.io.IOException, ClassNotFoundException { line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@666 PS35, Line 666: // it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor. line too long (132 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@668 PS35, Line 668: read(new org.apache.thrift.protocol.TCompactProtocol(new org.apache.thrift.transport.TIOStreamTransport(in))); line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@680 PS35, Line 680: private static class TableValidWriteIdsStandardScheme extends StandardScheme<TableValidWriteIds> { line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@682 PS35, Line 682: public void read(org.apache.thrift.protocol.TProtocol iprot, TableValidWriteIds struct) throws org.apache.thrift.TException { line too long (129 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@688 PS35, Line 688: if (schemeField.type == org.apache.thrift.protocol.TType.STOP) { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@696 PS35, Line 696: } else { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@704 PS35, Line 704: } else { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@722 PS35, Line 722: } else { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@730 PS35, Line 730: } else { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@738 PS35, Line 738: } else { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@751 PS35, Line 751: public void write(org.apache.thrift.protocol.TProtocol oprot, TableValidWriteIds struct) throws org.apache.thrift.TException { line too long (130 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@766 PS35, Line 766: oprot.writeListBegin(new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, struct.invalidWriteIds.size())); line too long (138 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@797 PS35, Line 797: private static class TableValidWriteIdsTupleScheme extends TupleScheme<TableValidWriteIds> { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@800 PS35, Line 800: public void write(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException { line too long (129 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@823 PS35, Line 823: public void read(org.apache.thrift.protocol.TProtocol prot, TableValidWriteIds struct) throws org.apache.thrift.TException { line too long (128 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@830 PS35, Line 830: org.apache.thrift.protocol.TList _list615 = new org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.I64, iprot.readI32()); line too long (144 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java File fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java@788 PS35, Line 788: public static void setNotificationEventCatName(NotificationEvent event, String catName) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/Hive2MetastoreShimBase.java@801 PS35, Line 801: public static void setInsertEventRequestDataReplace(InsertEventRequestData insertEventRequestData, line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@332 PS35, Line 332: && catName.equalsIgnoreCase(MetastoreShim.getNotificationEventCatName(notificationEvent)) line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@355 PS35, Line 355: && catName.equalsIgnoreCase(MetastoreShim.getNotificationEventCatName(notificationEvent)) line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1650 PS35, Line 1650: throw new CatalogException("Impala adapted to Apache Hive 2.x does not support synchronizing " + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2098 PS35, Line 2098: NotificationFilter filter = e -> MetastoreShim.isDefaultCatalog(MetastoreShim.getNotificationEventCatName(e)) line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java@1 PS35, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-apache-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1 PS35, Line 1: ../../../../../../../compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java File fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@861 PS35, Line 861: public static void setNotificationEventCatName(NotificationEvent event, String catName) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/compat-hive-3/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java@869 PS35, Line 869: public static void setInsertEventRequestDataReplace(InsertEventRequestData insertEventRequestData, line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/Table.java@931 PS35, Line 931: return MetastoreShim.getTableOwnerType(msTable_) == PrincipalType.USER ? msTable_.getOwner() : null; line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java File fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java@272 PS35, Line 272: MetastoreShim.setNotificationEventCatName(pseudoDropTableEvent, alterEvent.getCatalogName()); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java@282 PS35, Line 282: MetastoreShim.setNotificationEventCatName(pseudoCreateTableEvent, alterEvent.getCatalogName()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@236 PS35, Line 236: return MetastoreShim.getTableOwnerType(msTable_) == PrincipalType.USER ? msTable_.getOwner() : null; line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3343 PS35, Line 3343: MetastoreShim.getTableOwnerType(table.getMetaStoreTable()), /* newOwner */ null, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3650 PS35, Line 3650: MetastoreShim.truncateTable(client.getHiveClient(), dbName, hdfsTable.getName(), null, line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4134 PS35, Line 4134: /* oldOwnerType */ null, msTable.getOwner(), MetastoreShim.getTableOwnerType(msTable), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6498 PS35, Line 6498: MetastoreShim.setTableOwnerType(msTbl, PrincipalType.valueOf(params.owner_type.name())); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7973 PS35, Line 7973: MetastoreShim.setInsertEventRequestDataReplace(insertEventRequestData, isInsertOverwrite); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java File fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java: http://gerrit.cloudera.org:8080/#/c/21760/35/fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java@546 PS35, Line 546: (MetastoreShim.getTableOwnerType(tbl) != null) ? MetastoreShim.getTableOwnerType(tbl).name() : "null", tableInfo); line too long (122 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c Gerrit-Change-Number: 21760 Gerrit-PatchSet: 35 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 25 Jun 2025 07:01:19 +0000 Gerrit-HasComments: Yes
