Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23106 )
Change subject: IMPALA-14163: (Addendum) Always reset max-query-mem-limit ...................................................................... IMPALA-14163: (Addendum) Always reset max-query-mem-limit test_pool_config_change_while_queued now consistently pass in TestAdmissionController and fail in TestAdmissionControllerWithACService. The root cause of this issue is because copy-mem-limit-test-llama-site.xml is only copied once for both tests. TestAdmissionController left max-query-mem-limit of invalidTestPool at 25MB without resetting it back to 0, which then cause test failure at TestAdmissionControllerWithACService. This patch improve the test by always setting max-query-mem-limit of invalidTestPool at 0 both in the beginning and the end of test. Change ResourcePoolConfig to use mem_limit_coordinators and mem_limit_executors because, unlike mem_limit option, they are not subject to pool-level memory clamping. Disable --clamp_query_mem_limit_backend_mem_limit flag so that coord_backend_mem_limit is not clamped to coordinator's process limit. Removed make_copy parameter in test_pool_mem_limit_configs since it does not mutate the config files. Added more log details in admission-controller.cc to help make better association. Testing: - Loop and pass the test in ARM build. Change-Id: I41f671b8fb3eabf263041a834b54740fbacda68e Reviewed-on: http://gerrit.cloudera.org:8080/23106 Reviewed-by: Yida Wu <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/scheduling/admission-controller.cc M tests/common/resource_pool_config.py M tests/custom_cluster/test_admission_controller.py 3 files changed, 45 insertions(+), 22 deletions(-) Approvals: Yida Wu: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/23106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I41f671b8fb3eabf263041a834b54740fbacda68e Gerrit-Change-Number: 23106 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
