Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala ...................................................................... Patch Set 42: (3 comments) Thanks for reviving this! Nice to see most of the tests are passed. The failed one seems to be a flaky test. http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@332 PS42, Line 332: MetastoreShim.getNotificationEventCatName( : notificationEvent) This is the main difference between MetastoreEventsProcessor implementations of Apache Hive 2 and other Hive versions. Can we just add this getNotificationEventCatName() method in MetastoreShim of other Hive versions to avoid duplicating MetastoreEventsProcessor for each of them? http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-apache-hive-2/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1652 PS42, Line 1652: "Impala adapted to Apache Hive 2.x does not support " + : "synchronizing metadata by processing metadata events." Is it intended to not support this? I think in CDH6 we still support it and CDH6 uses Hive-2. http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21760/42/fe/src/compat-hive-3/java/org/apache/impala/catalog/events/MetastoreEvents.java@3532 PS42, Line 3532: } Moving these files has a great impact for future development. Backporting fixes to older branches will be hard. It'd be nice if we can keep MetastoreEvents and MetastoreEventsProcessor, and just extract some codes into MetastoreShim implementations. -- To view, visit http://gerrit.cloudera.org:8080/21760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c Gerrit-Change-Number: 21760 Gerrit-PatchSet: 42 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Thu, 03 Jul 2025 03:56:16 +0000 Gerrit-HasComments: Yes
