Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23110 )
Change subject: [tools] Add a script to create 300K tables efficiently ...................................................................... Patch Set 2: (3 comments) Thanks Quanlong! http://gerrit.cloudera.org:8080/#/c/23110/2/testdata/scale_test_metadata/create_300k_tables.py File testdata/scale_test_metadata/create_300k_tables.py: http://gerrit.cloudera.org:8080/#/c/23110/2/testdata/scale_test_metadata/create_300k_tables.py@30 PS2, Line 30: 301 Is it intentional that this is not 300k? http://gerrit.cloudera.org:8080/#/c/23110/2/testdata/scale_test_metadata/create_300k_tables.py@31 PS2, Line 31: DB_NAME = "db_300k" The script could also create the DB if it does not exist. http://gerrit.cloudera.org:8080/#/c/23110/2/testdata/scale_test_metadata/create_300k_tables.py@59 PS2, Line 59: partField.name = "part" Shouldn't these come from 'part_cols'? -- To view, visit http://gerrit.cloudera.org:8080/23110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73bbc4a3ae5bfbfbb508052b4c68b0044f951ac6 Gerrit-Change-Number: 23110 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 03 Jul 2025 09:13:12 +0000 Gerrit-HasComments: Yes
