Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22997 )
Change subject: IMPALA-13801: Support greatest synced event with hierarchical metastore event processing ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/22997/12/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/22997/12/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1156 PS12, Line 1156: org.apache.hadoop.hive.metastore.api.Table tbl = event.getCatalogOpExecutor() : .getCatalog().getTable(entry.getKey().getDb(), entry.getKey().getTbl()) : .getMetaStoreTable() In what situation does tbl == null ? Is it possible for event.getCatalogOpExecutor().getCatalog().getTable() itself to return null? http://gerrit.cloudera.org:8080/#/c/22997/11/fe/src/main/java/org/apache/impala/catalog/events/DbEventExecutor.java File fe/src/main/java/org/apache/impala/catalog/events/DbEventExecutor.java: http://gerrit.cloudera.org:8080/#/c/22997/11/fe/src/main/java/org/apache/impala/catalog/events/DbEventExecutor.java@317 PS11, Line 317: synchronized (processorLock_) { : if (isTerminating()) return; : Preconditions.checkState(barrierEvents_.poll() == barrierEvent); : dbEventExecutor_.decrOutstandingEventCount(1); : } > postProcessEvent(event) does the post operations related to the particular Done http://gerrit.cloudera.org:8080/#/c/22997/11/fe/src/main/java/org/apache/impala/catalog/events/DbEventExecutor.java@323 PS11, Line 323: // Throwing EventProcessException triggers global invalidate > Done. Yes, it requires invalidate metadata and that resets everything insid Can you double check this statement please? There are 3 call sites to handleEventProcessException(), but only 1 followed up by finally block eventExecutorService_.cleanup(); https://gerrit.cloudera.org/c/22997/12/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java#1358 That means, the other 2 will not reset eventExecutorService_? http://gerrit.cloudera.org:8080/#/c/22997/11/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java File fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java: http://gerrit.cloudera.org:8080/#/c/22997/11/fe/src/main/java/org/apache/impala/catalog/events/TableEventExecutor.java@332 PS11, Line 332: synchronized (processorLock_) { : if (isTerminating()) return; : Preconditions.checkState(events_.poll() == event); : tableEventExecutor_.decrOutstandingEventCount(1); : } > postProcessEvent(event) does the post operations related to the particular Done -- To view, visit http://gerrit.cloudera.org:8080/22997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26240f36aaf85125428dc39a66a2a1e4d3197e85 Gerrit-Change-Number: 22997 Gerrit-PatchSet: 12 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 07 Jul 2025 16:27:35 +0000 Gerrit-HasComments: Yes
