Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23118 )
Change subject: IMPALA-14017: Add Ranger tests to Iceberg REST Catalog ...................................................................... Patch Set 2: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/23118/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23118/2/tests/authorization/test_ranger.py@3237 PS2, Line 3237: REST_SERVER_PORT = 9084 : IMPALA_HOME = os.environ['IMPALA_HOME'] > nit: not needed Done http://gerrit.cloudera.org:8080/#/c/23118/2/tests/authorization/test_ranger.py@3306 PS2, Line 3306: """Run iceberg-rest-catalog.test with all the required privileges.""" > Can you add a negative test as well? Added a select query against table 'parquet_orc' for which we don't have privilege. Row filtering is tested via 'SELECT distinct country FROM airports_parquet;' Or do you mean to run every query from iceberg-rest-catalog.test and catch the errors? http://gerrit.cloudera.org:8080/#/c/23118/2/tests/common/iceberg_rest_server.py File tests/common/iceberg_rest_server.py: http://gerrit.cloudera.org:8080/#/c/23118/2/tests/common/iceberg_rest_server.py@18 PS2, Line 18: from __future__ import absolute_import, division, print_function > This import was added after PS1, might it be unused? These imports are mandatory, otherwise the job gerrit-code-review-checks fails, see failure for PS1: https://jenkins.impala.io/job/gerrit-code-review-checks/19673/artifact/https%3A%5E%5Ejenkins.impala.io%5Ejob%5Epython-check-ub2004%5E8275%5E.log -- To view, visit http://gerrit.cloudera.org:8080/23118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d506e04537c5ca878ab9cf58792bc8a6b560c3 Gerrit-Change-Number: 23118 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 08 Jul 2025 11:32:24 +0000 Gerrit-HasComments: Yes
