Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/22554 )
Change subject: IMPALA-13593: Enable event processor to consume ALTER_PARTITIONS events from metastore ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/22554/7/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/22554/7/be/src/catalog/catalog-server.cc@223 PS7, Line 223: NS,CREATE_TABLE, > Is it intended to skip ALTER_PARTITION events after this patch? Are there s I intend to remove ADD_PARTITION,ALTER_PARTITION, DROP_PARTITION which are duplicates and add ALTER_PARTITIONS http://gerrit.cloudera.org:8080/#/c/22554/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/22554/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@634 PS7, Line 634: tableReloadInfo = new TableReloadInfo(msTbl, partitionsAfter, isTruncateOp); : } catch (Exception e) { : throw new MetastoreNotificationException(e); > nit: It might be better to define a class for this. Then we don't need cast Ack http://gerrit.cloudera.org:8080/#/c/22554/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22554/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2860 PS7, Line 2860: ed from a single initial > nit: use getEventDesc() Ack http://gerrit.cloudera.org:8080/#/c/22554/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2866 PS7, Line 2866: MetastoreTableEvent { > nit: L2843-2866 are quite similar to codes in AlterPartitionEvent#processTa Ack http://gerrit.cloudera.org:8080/#/c/22554/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2878 PS7, Line 2878: : @Override : public MetastoreEvent addToBatchEvents(MetastoreEvent event) { : Preconditions.checkState(canBeBatched(event)); : batchedEvents_.add((T) event); : return this; : } : : @Override : public int getNumberOfEvents() { return batchedEvents_.size(); } : > nit: These are also simlar to the implementation in AlterPartitionEvent. Ca Ack -- To view, visit http://gerrit.cloudera.org:8080/22554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I009a87ef5e2c331272f9e2d7a6342cc860e64737 Gerrit-Change-Number: 22554 Gerrit-PatchSet: 8 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 10 Jul 2025 05:52:32 +0000 Gerrit-HasComments: Yes
