Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23156 )
Change subject: IMPALA-14018: Configure OAUTH2 with Lakekeeper and fix Impala's config handling ...................................................................... Patch Set 1: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23156/1/fe/src/main/java/org/apache/impala/catalog/iceberg/RESTCatalogProperties.java File fe/src/main/java/org/apache/impala/catalog/iceberg/RESTCatalogProperties.java: http://gerrit.cloudera.org:8080/#/c/23156/1/fe/src/main/java/org/apache/impala/catalog/iceberg/RESTCatalogProperties.java@80 PS1, Line 80: public boolean applyConfig(Map<String, String> sourceMap, Map<String, String> outputMap) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23156/1/fe/src/main/java/org/apache/impala/catalog/iceberg/RESTCatalogProperties.java@132 PS1, Line 132: public boolean applyConfig(Map<String, String> sourceMap, Map<String, String> outputMap) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23156/1/fe/src/main/java/org/apache/impala/catalog/iceberg/RESTCatalogProperties.java@150 PS1, Line 150: public boolean applyConfig(Map<String, String> sourceMap, Map<String, String> outputMap) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23156/1/fe/src/main/java/org/apache/impala/catalog/iceberg/RESTCatalogProperties.java@172 PS1, Line 172: public boolean applyConfig(Map<String, String> sourceMap, Map<String, String> outputMap) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23156/1/fe/src/main/java/org/apache/impala/catalog/iceberg/RESTCatalogProperties.java@213 PS1, Line 213: // Since currently only OAUTH2 is possible we ignore this config. It also doesn't map to line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23156/1/fe/src/test/java/org/apache/impala/catalog/iceberg/TestRESTCatalogProperties.java File fe/src/test/java/org/apache/impala/catalog/iceberg/TestRESTCatalogProperties.java: http://gerrit.cloudera.org:8080/#/c/23156/1/fe/src/test/java/org/apache/impala/catalog/iceberg/TestRESTCatalogProperties.java@135 PS1, Line 135: assertEquals("false", catProps.get("iceberg.rest-catalog.vended-credentials-enabled")); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23156/1/testdata/bin/minicluster_lakekeeper/setup.sh File testdata/bin/minicluster_lakekeeper/setup.sh: http://gerrit.cloudera.org:8080/#/c/23156/1/testdata/bin/minicluster_lakekeeper/setup.sh@9 PS1, Line 9: TOKEN=$(curl -s -X POST "http://localhost:7070/realms/lakekeeper-realm/protocol/openid-connect/token"; \ line too long (103 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23156 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5785cb72773e188b1de7c7924cc6f0b1f96de33 Gerrit-Change-Number: 23156 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 10 Jul 2025 17:01:30 +0000 Gerrit-HasComments: Yes
