Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21803 )

Change subject: IMPALA-915: Support cancel queries in frontend
......................................................................


Patch Set 54:

> Patch Set 54:
>
> > Patch Set 54: Verified-1
> >
> > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12140/
> 
> The test_idempotence is a real behavioral change due to retaining error 
> messages for interrupted queries. I'm inclined to update the test. The 
> ergonomics are not ideal though, it says
>
>   Query 7c4e92b694ac7865:b1f986ed00000000 failed:
>   Cancelled
>
> The dockerized test failure on test_query_cancel_load_metadata is troubling. 
> The test takes a lot longer than it should.

Oh, Docker containers set use_local_catalog=true. So 'invalidate metadata' is 
no longer slow. I'll have to work on how to update the test for that.


--
To view, visit http://gerrit.cloudera.org:8080/21803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86
Gerrit-Change-Number: 21803
Gerrit-PatchSet: 54
Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jul 2025 22:43:32 +0000
Gerrit-HasComments: No

Reply via email to