Sanjana Malhotra has posted comments on this change. ( http://gerrit.cloudera.org:8080/23031 )
Change subject: IMPALA-12648: [DOCS] Documentation for Kill Query statements ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/23031/2/docs/impala.ditamap File docs/impala.ditamap: http://gerrit.cloudera.org:8080/#/c/23031/2/docs/impala.ditamap@281 PS2, Line 281: <topicref href="topics/impala_values.xml"/> > I think this list is generally meant to be sorted alphabetically. Ack http://gerrit.cloudera.org:8080/#/c/23031/3/docs/topics/impala_kill_query.xml File docs/topics/impala_kill_query.xml: http://gerrit.cloudera.org:8080/#/c/23031/3/docs/topics/impala_kill_query.xml@24 PS3, Line 24: KILL QUERY > How about changing it to all upper-case letters, as in docs/topics/impala_s Done http://gerrit.cloudera.org:8080/#/c/23031/3/docs/topics/impala_kill_query.xml@44 PS3, Line 44: lt;'<var > How about adding a <varname> tag, as in docs/topics/impala_shutdown.xml? Done http://gerrit.cloudera.org:8080/#/c/23031/4/docs/topics/impala_kill_query.xml File docs/topics/impala_kill_query.xml: http://gerrit.cloudera.org:8080/#/c/23031/4/docs/topics/impala_kill_query.xml@44 PS4, Line 44: < > Maybe we don't need to add < and > here. My point of view was that it makes sense when describing syntax. -- To view, visit http://gerrit.cloudera.org:8080/23031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51efbdeb585bad358b3e44ea4f555f62bfee4f00 Gerrit-Change-Number: 23031 Gerrit-PatchSet: 4 Gerrit-Owner: Sanjana Malhotra <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Sanjana Malhotra <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 11 Jul 2025 07:19:30 +0000 Gerrit-HasComments: Yes
