Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 )
Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location ...................................................................... Patch Set 9: Code-Review+1 > (1 comment) > > Thanks for your comments, Sailesh! This change doesn't cover the > case when 2 partitions from different tables point to the same > location. I'm not sure that it's a valid real world scenario. I > mean I tried and it's feasible to do this but form me it doesn't > make sense to point one partition to a different table's directory > in the file system. Do you think we should make this documented? I > think that it also has to be documented that all the other > partitions are dropped on a same location when you drop one of > them. I was under the impression that 2 tables with the same structure could have partitions pointing to the same location, but maybe that's an extreme edge case and we don't need to worry about it. Yes, let's at least document the purpose of this patch. We can open a seperate docs JIRA for that. Thanks for fixing all this so far. This LGTM! I'll let Bharath sign off. -- To view, visit http://gerrit.cloudera.org:8080/10543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a54bc8224bcefe65b83de2df58bb84629f2aa4a Gerrit-Change-Number: 10543 Gerrit-PatchSet: 9 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Jun 2018 15:49:45 +0000 Gerrit-HasComments: No
