Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23168 )
Change subject: IMPALA-14220: CatalogServer::IsActive must not hold catalog_lock_ ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23168/2/be/src/catalog/catalog-server.h File be/src/catalog/catalog-server.h: http://gerrit.cloudera.org:8080/#/c/23168/2/be/src/catalog/catalog-server.h@228 PS2, Line 228: AtomicBool It seems we are not using any atomic feature like CAS operations. Maybe declaring this as volatile is enough. The only writer is the UpdateActiveCatalogd thread which is always a single thread due to catalog_lock_. -- To view, visit http://gerrit.cloudera.org:8080/23168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15fb925f1eb4ea5d213075b66a676d2bc9b9e9f1 Gerrit-Change-Number: 23168 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 15 Jul 2025 00:57:42 +0000 Gerrit-HasComments: Yes
