Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23185 )
Change subject: IMPALA-14094: Prepend to commit, refactor estimated table stats ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23185/4/fe/src/main/java/org/apache/impala/planner/HdfsEstimatedMissingTableStats.java File fe/src/main/java/org/apache/impala/planner/HdfsEstimatedMissingTableStats.java: http://gerrit.cloudera.org:8080/#/c/23185/4/fe/src/main/java/org/apache/impala/planner/HdfsEstimatedMissingTableStats.java@40 PS4, Line 40: public final int numPartitionsWithNumRows_; nit: preserving the code comments here could be nice if they're still relevant. http://gerrit.cloudera.org:8080/#/c/23185/4/fe/src/main/java/org/apache/impala/planner/HdfsEstimatedMissingTableStats.java@108 PS4, Line 108: partitionNumRows_ = partitionNumRows; Why do it this way? So the class variables can be final? -- To view, visit http://gerrit.cloudera.org:8080/23185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I522e5105867fa1c85df5c04a4bc6cdd5d63443f0 Gerrit-Change-Number: 23185 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Tue, 22 Jul 2025 21:17:39 +0000 Gerrit-HasComments: Yes
