Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23122 )
Change subject: IMPALA-14094: Calcite planner: Use table and column statistics for optimization ...................................................................... Patch Set 9: Code-Review+1 (5 comments) Updated patch lgtm. Will wait for a bit in case other reviewers have additional comments. http://gerrit.cloudera.org:8080/#/c/23122/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java: http://gerrit.cloudera.org:8080/#/c/23122/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@56 PS7, Line 56: > Done Done http://gerrit.cloudera.org:8080/#/c/23122/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@215 PS7, Line 215: /** > I actually grabbed this code (and comment) from Hive, so we wouldn't be abl Done http://gerrit.cloudera.org:8080/#/c/23122/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@262 PS7, Line 262: : * Given a RexCall of kind I > Made this more specific and added some preconditions Done http://gerrit.cloudera.org:8080/#/c/23122/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java: http://gerrit.cloudera.org:8080/#/c/23122/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java@45 PS3, Line 45: RelMdRowCo > Done Done http://gerrit.cloudera.org:8080/#/c/23122/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java@48 PS3, Line 48: public class ImpalaRelMdRowCount extends RelMdRowCount { > Ok, for Aggregates, I was trying to see how the selectivity for an Agg wit Done -- To view, visit http://gerrit.cloudera.org:8080/23122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5bb50eb562c28e4b7c7a6529d140f98e77295c Gerrit-Change-Number: 23122 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 24 Jul 2025 14:53:31 +0000 Gerrit-HasComments: Yes
