Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23194 )
Change subject: IMPALA-14220 (part 2): Delay AcceptRequest until catalog is stable ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/23194/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23194/7//COMMIT_MSG@25 PS7, Line 25: min_catalog_resets_to_serve_ numCatalogResetStarts_ http://gerrit.cloudera.org:8080/#/c/23194/7/be/src/catalog/catalog-server.h File be/src/catalog/catalog-server.h: http://gerrit.cloudera.org:8080/#/c/23194/7/be/src/catalog/catalog-server.h@316 PS7, Line 316: /// Set min_catalog_version_to_serve_ to the current catalog version + : /// Catalog.CATALOG_VERSION_AFTER_FIRST_RESET (100) to delay AcceptRequest() : /// until the reset operation begin in JVM. Stale docs. http://gerrit.cloudera.org:8080/#/c/23194/7/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/23194/7/be/src/catalog/catalog-server.cc@617 PS7, Line 617: min_catalog_resets_to_serve_{0} Should this init to 1? http://gerrit.cloudera.org:8080/#/c/23194/7/be/src/catalog/catalog-server.cc@860 PS7, Line 860: remove whitespace. http://gerrit.cloudera.org:8080/#/c/23194/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/23194/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@307 PS7, Line 307: numCatalogResetStarts_ Make this AtomicLong so that read/write does not need to hold catalog_lock_? -- To view, visit http://gerrit.cloudera.org:8080/23194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I370d21319335318e441ec3c3455bac4227803900 Gerrit-Change-Number: 23194 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sat, 26 Jul 2025 05:26:47 +0000 Gerrit-HasComments: Yes
