Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 )
Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10611/2/fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java: http://gerrit.cloudera.org:8080/#/c/10611/2/fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java@220 PS2, Line 220: HdfsPartition > nit: add a todo for the downcast. I don't think this one merits a TODO because it's in test code that's specific to the catalogd implementation -- the new implementation won't need TCatalogObject and friends since that's only used for the catalogd->impalad propagation protocol, right? -- To view, visit http://gerrit.cloudera.org:8080/10611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id55f7d2e94d81e66ce720acb6315f15a89621b31 Gerrit-Change-Number: 10611 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Jun 2018 23:47:20 +0000 Gerrit-HasComments: Yes