Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23217 )
Change subject: IMPALA-10866: Add testcases for failure cases involving the admission service ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/23217/2/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23217/2/tests/custom_cluster/test_admission_controller.py@2270 PS2, Line 2270: create_hs2_client() > Nit: Beeswax is deprecated, use HS2 instead. Done http://gerrit.cloudera.org:8080/#/c/23217/2/tests/custom_cluster/test_admission_controller.py@2277 PS2, Line 2277: create_hs2_client() > Nit: Beeswax is deprecated, use HS2 instead. Done http://gerrit.cloudera.org:8080/#/c/23217/2/tests/custom_cluster/test_admission_controller.py@2292 PS2, Line 2292: @SkipIfNotHdfsMinicluster.tuned_for_minicluster > Is there a need to restart the coordinator here or will the next test take Seems no need. Removed. -- To view, visit http://gerrit.cloudera.org:8080/23217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If617326cbc6fe2567857d6323c6413d98c92d009 Gerrit-Change-Number: 23217 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 04 Aug 2025 17:47:14 +0000 Gerrit-HasComments: Yes
