Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23258 )
Change subject: IMPALA-14263: Add broadcast_cost_scale to tweak broadcast join cost ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23258/3/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/23258/3/common/thrift/ImpalaService.thrift@1046 PS3, Line 1046: BROADCAST_COST_SCALE = 194 Can we call this 'broadcast_cost_scale_factor' to be consistent with the naming of other similar multiplicative factor ? The name ending with _scale gives the impression of a size (as in tpcds scale). http://gerrit.cloudera.org:8080/#/c/23258/3/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-dist-method.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-dist-method.test: http://gerrit.cloudera.org:8080/#/c/23258/3/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-dist-method.test@603 PS3, Line 603: ---- PLAN Since this test is only relevant for distributed plan, is it necessary to capture the single node plan or should this section be skipped ? I am ok if you want to keep it for some reason. -- To view, visit http://gerrit.cloudera.org:8080/23258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I475f8a26b2171e87952b69f66a5c18f77c2b3133 Gerrit-Change-Number: 23258 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 06 Aug 2025 02:54:10 +0000 Gerrit-HasComments: Yes
