Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22554 )
Change subject: IMPALA-13593: Enable event processor to consume ALTER_PARTITIONS events from metastore ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/22554/13/fe/src/test/resources/hive-site.xml.py File fe/src/test/resources/hive-site.xml.py: http://gerrit.cloudera.org:8080/#/c/22554/13/fe/src/test/resources/hive-site.xml.py@98 PS13, Line 98: elif VARIANT == 'events_config_change': : # HMS config change needed for HIVE-27746 to emit ALTER_PARTITIONS event : CONFIG.update({ : 'hive.metastore.alterPartitions.notification.v2.enabled': 'true', : }) With CDP_BUILD_NUMBER bumped up, why this need its own VARIANT? Isn't it better to set it by default? http://gerrit.cloudera.org:8080/#/c/22554/13/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/22554/13/tests/custom_cluster/test_events_custom_configs.py@1669 PS13, Line 1669: # Case-I: compute stats # Case-I: compute stats from hive nit: Please add blank line between test cases. http://gerrit.cloudera.org:8080/#/c/22554/13/tests/util/event_processor_utils.py File tests/util/event_processor_utils.py: http://gerrit.cloudera.org:8080/#/c/22554/13/tests/util/event_processor_utils.py@89 PS13, Line 89: timeout=10000 Is shorter default timeout (ie., 60 seconds) sufficient? The new test_alter_partitions_event_from_metastore also set 10s timeout everywhere. -- To view, visit http://gerrit.cloudera.org:8080/22554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I009a87ef5e2c331272f9e2d7a6342cc860e64737 Gerrit-Change-Number: 22554 Gerrit-PatchSet: 13 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 06 Aug 2025 21:11:40 +0000 Gerrit-HasComments: Yes
