Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23254 )
Change subject: IMPALA-12108: Add support for LZ4 high compression levels ...................................................................... Patch Set 7: (3 comments) I'm unstacking this from IMPALA-14294 to make it easier to merge. http://gerrit.cloudera.org:8080/#/c/23254/7/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: http://gerrit.cloudera.org:8080/#/c/23254/7/be/src/service/query-options-test.cc@712 PS7, Line 712: ++i > nit: can be i++ matching with other loops in file Done http://gerrit.cloudera.org:8080/#/c/23254/7/be/src/service/query-options-test.cc@724 PS7, Line 724: LZ4HC_CLEVEL_MAX+1 > nit: binary operator spacing Done http://gerrit.cloudera.org:8080/#/c/23254/7/be/src/util/compress.h File be/src/util/compress.h: http://gerrit.cloudera.org:8080/#/c/23254/7/be/src/util/compress.h@142 PS7, Line 142: std::optional<int> compression_level = std::nullopt); > Just a heads up that I also wanted add a similar config for "acceleration", That's interesting. I hadn't noticed that LZ4_compress_fast() API. That's worth benchmarking for RPC compression. With fast networks, it could make sense to do faster compression. -- To view, visit http://gerrit.cloudera.org:8080/23254 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7470ce38b8710c870cacebc80bc02cf5d022791 Gerrit-Change-Number: 23254 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Aug 2025 17:19:00 +0000 Gerrit-HasComments: Yes
