Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23293 )
Change subject: IMPALA-13237: Match Behavior of Older Impala Versions ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/23293/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23293/5//COMMIT_MSG@9 PS5, Line 9: Older versions of Impala set exec_state_ in ClientRequestState to : the error state earlier in the query processing than later versions. > nit: Can you tell us which Impala JIRA change this? I dug through the commits/jiras and was unable to narrow it down to any specific commit/jira. http://gerrit.cloudera.org:8080/#/c/23293/5/tests/util/query_profile_util.py File tests/util/query_profile_util.py: http://gerrit.cloudera.org:8080/#/c/23293/5/tests/util/query_profile_util.py@127 PS5, Line 127: \n > I might be wrong but do you think it'd be better to replace it with '(?:\n| Good question. This regex is doing text parsing of an Impala Query profile, thus there will always be a newline at the end of the line. -- To view, visit http://gerrit.cloudera.org:8080/23293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If57aaef2da6d6904c66d0150f50ea9ac1c3ebc8c Gerrit-Change-Number: 23293 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 14 Aug 2025 20:49:23 +0000 Gerrit-HasComments: Yes
