Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23300 )

Change subject: IMPALA-14312: Fix Issues with ssl_minimum_version Flag Validator
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23300/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/23300/1/be/src/service/impala-server.cc@a266
PS1, Line 266:
> I built and ran rpc-mgr-test, thrift-server-test, impala-server-test, and w
Ack


http://gerrit.cloudera.org:8080/#/c/23300/1/be/src/service/impala-server.cc@260
PS1, Line 260: DEFINE_validator(ssl_minimum_version, [](const char* flagname, 
const string& value) {
> Those validators do allow tlsv1.3, but, since Thrift does not support using
Ack



--
To view, visit http://gerrit.cloudera.org:8080/23300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6493852b581e26c203b6b46b97be76100bcc534b
Gerrit-Change-Number: 23300
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Aug 2025 21:19:12 +0000
Gerrit-HasComments: Yes

Reply via email to