Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources ...................................................................... Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/10626/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10626/2//COMMIT_MSG@12 PS2, Line 12: IMPALA-7131 pls mark these with todo's that reference this jira. http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java File fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java: http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@42 PS2, Line 42: Represents a table backed by an external data source. pull this part up into the interface. http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/FeDataSource.java File fe/src/main/java/org/apache/impala/catalog/FeDataSource.java: http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/FeDataSource.java@21 PS2, Line 21: * Interface for interacting with data sources from the frontend. nit: use consistent phrasing with the other interfaces "Frontend interface for interacting with data sources." -- To view, visit http://gerrit.cloudera.org:8080/10626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e Gerrit-Change-Number: 10626 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Jun 2018 18:01:49 +0000 Gerrit-HasComments: Yes
