Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23326 )
Change subject: IMPALA-14336: Avoid loading tables during table listing in the IcebergMetaProvider ...................................................................... Patch Set 2: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/23326/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23326/1//COMMIT_MSG@9 PS1, Line 9: IcebergMetaProvider unnecessarily loads Iceberg tables in : loadTableList(). > Can you add that the new state is consistent with CatalogdMetaProvider, whi Done http://gerrit.cloudera.org:8080/#/c/23326/1//COMMIT_MSG@17 PS1, Line 17: that the tables returned by an Iceberg REST : Catalog are loadable. Even if they are not, > Just curious, do we already throw an exception or is it a TODO, we can mayb We throw an exception when we try to use such tables. Added another sentence about it. http://gerrit.cloudera.org:8080/#/c/23326/1//COMMIT_MSG@20 PS1, Line 20: is aligned with CatalogdMetaProvider, i.e. the tables are listed : without fully loading them, and we only get an error when we want > Maybe also add a point that this patch also cleans the existing erroneous t Extended the "existing tests updated" sentence below to make it more clear. -- To view, visit http://gerrit.cloudera.org:8080/23326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ff75a751be5ad4b5159a1294eaaa304049c454a Gerrit-Change-Number: 23326 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pranav Lodha <pranav.lo...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Aug 2025 13:22:24 +0000 Gerrit-HasComments: Yes
