Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/23237 )
Change subject: IMPALA-14285: Add SAML2 authentication support for Impala Web UI ...................................................................... Patch Set 6: (3 comments) Fixed memory management; minor refactoring. http://gerrit.cloudera.org:8080/#/c/23237/2/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23237/2/be/src/util/webserver.cc@977 PS2, Line 977: tRemoteAddress(r > It could be a different ticket under IMPALA-13819 Ack, created IMPALA-14346. http://gerrit.cloudera.org:8080/#/c/23237/2/be/src/util/webserver.cc@992 PS2, Line 992: if (host.empty()) return returnSamlAuthFailure(connection); : request->path += host > >We can just return Unauthorized instead of DCHECK though. Done http://gerrit.cloudera.org:8080/#/c/23237/1/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/23237/1/tests/common/impala_service.py@82 PS1, Line 82: this t > >not just the commit message. Ack -- To view, visit http://gerrit.cloudera.org:8080/23237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12540300529f9c240abf7196141ecb0ae6e37995 Gerrit-Change-Number: 23237 Gerrit-PatchSet: 6 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Aug 2025 14:37:06 +0000 Gerrit-HasComments: Yes
