Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23345 )
Change subject: IMPALA-14160: Omit compression, encryption, EC in cache key ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23345/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/23345/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2702 PS1, Line 2702: // Ignore file_compression, it does not impact file contents. : scanRange.hdfs_file_split.file_compression = THdfsCompression.NONE; : // Ignore is_encrypted, it does not impact file contents. : scanRange.hdfs_file_split.unsetIs_encrypted(); : // Ignore erasure coding, it does not impact file contents. : scanRange.hdfs_file_split.unsetIs_erasure_coded(); I am not familiar with the tuple cache - do we consider the size of files? If yes, then using compression could affect whether it is considered the same file or not. Based on the commit message the issue is not about an actual change in these flags, but that Ozone hides this information. This could be reflected in the comments here. -- To view, visit http://gerrit.cloudera.org:8080/23345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3595003b9e1fbbd95524b196db002b857acd7870 Gerrit-Change-Number: 23345 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 26 Aug 2025 05:07:33 +0000 Gerrit-HasComments: Yes
