Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 )
Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog ...................................................................... Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/10629/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10629/2//COMMIT_MSG@21 PS2, Line 21: except when a full catalog update is received. just to clarify, state that this is the behavior today. http://gerrit.cloudera.org:8080/#/c/10629/2/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/10629/2/be/src/runtime/exec-env.cc@87 PS2, Line 87: required nit: used http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java File fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java: http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java@167 PS2, Line 167: name_.toLowerCase() there have been a number of bugs with inconsistent case handling. just wondering why this tolower was used and whether we can make the choice more explicit. http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/FeCatalogManager.java File fe/src/main/java/org/apache/impala/service/FeCatalogManager.java: http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/FeCatalogManager.java@30 PS2, Line 30: implementations implementation? I assume its only one at a time. http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/FeCatalogManager.java@30 PS2, Line 30: Managers nit: Manages http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/FeCatalogManager.java@126 PS2, Line 126: } nit: add a newline for consistency http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/Frontend.java@168 PS2, Line 168: authzChecker_ where is this set/used? http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/Frontend.java@187 PS2, Line 187: /** : * C'tor used by tests to pass in a custom ImpaladCatalog. : */ stale comment? this looks like the core constructor so should it be public? looks like the standard entry point is L173 whereas for tests, we should use L182. I don't think this was clear before... the construction in JniFrontend used L174 and then used this "test" constructor. http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/Frontend.java@197 PS2, Line 197: policyReaderTask.run(); why is this run here? I would think scheduling on L204 would do this. if needed, perhaps it can be run in an else clause of L199. also, since authzChecker_ is not set here, something looks off. -- To view, visit http://gerrit.cloudera.org:8080/10629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c9665bd031d23608740b23eef301970af9aa764 Gerrit-Change-Number: 10629 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Jun 2018 18:03:56 +0000 Gerrit-HasComments: Yes
