Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23319 )

Change subject: IMPALA-14333: Run impala-py.test using Python3
......................................................................


Patch Set 17: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG@42
PS5, Line 42: test_shell_commandline.py, and test_shell_interactive.py.
> Done
Done


http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG@45
PS5, Line 45:
> Personally, I rather move away from python2 totally. There are only few tes
Ack.  I also misunderstood this.  Python 2 test dimension will still get 
generated when system Python 2 is available which will run Python 2 tests 
against Python 2 impala-shell.  The only dimension not generated is Python 3 
tests against Python 2 impala-shell which makes sense.
https://gerrit.cloudera.org/c/23319/17/tests/shell/util.py#390


http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG@59
PS5, Line 59: Several test logic require modification due to intermittent issue 
in
> I suspect some custom cluster test unknowingly start HiveServer2 manually (
Done



--
To view, visit http://gerrit.cloudera.org:8080/23319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401a93b6cc7bcd17f41d24e7a310e0c882a550d4
Gerrit-Change-Number: 23319
Gerrit-PatchSet: 17
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 19:07:40 +0000
Gerrit-HasComments: Yes

Reply via email to