Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23416 )
Change subject: IMPALA-14426: Deflake TestImpalaShell.test_cancellation ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23416/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23416/2//COMMIT_MSG@7 PS2, Line 7: Deflake TestImpalaShell.test_cancellation > Is this really just a test issue? Can't we have problems (at least not info I'm not sure if there is anything else that we overlook. But looping test_cancellation does not reveal anything else. All pass. Perhaps we shall see something else once in downstream tests once we merged this? http://gerrit.cloudera.org:8080/#/c/23416/2/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/23416/2/shell/impala_shell/impala_shell.py@740 PS2, Line 740: new_imp_client = self._new_impala_client() : new_imp_client.connect() : try: : new_imp_client.cancel_query(self.last_query_handle) : new_imp_client.close_query(self.last_query_handle) > Can't we have other similar issues if these functions do some logging? Ther Agree that we might have similar issue if this code block does logging anywhere. Fortunately, searching around impala_client.py, that does not seem to be the case. -- To view, visit http://gerrit.cloudera.org:8080/23416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5403c7b8126b1a35ea841496fdfb6eb93e83376e Gerrit-Change-Number: 23416 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 12 Sep 2025 15:06:39 +0000 Gerrit-HasComments: Yes
