Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23384 )
Change subject: IMPALA-14139: Enable Impala builds on Ubuntu 24.04 ...................................................................... IMPALA-14139: Enable Impala builds on Ubuntu 24.04 Update the following elements of the Impala build environment to enable builds on Ubuntu 24.04: - Recognize and handle (where necessary) Ubuntu 24.04 in various bootstrap scripts (bootstrap_system.sh, bootstrap_toolchain.py, etc.) - Bump IMPALA_TOOLCHAIN_ID to an official toolchain build that contains Ubuntu 24.04-specific binary packages - Bump binutils to 2.42, and - Bump the GDB version to 12.1-p1, as required by the new toolchain version - Update unique_ptr usage syntax in be/src/util/webserver-test.cc to compensate for new GLIBC funtion prototypes: System headers in Ubuntu 24.04 adopted attributes on several widely used function prototypes. Such attributes are not considered to be part of the function's signature during template evaluation, so GCC throws a warning when such a function is passed as a template argument, which breaks the build, as warnings are treated as errors. webserver-test.cc uses pclose() as the deleter for a unique_ptr in a utility function. This patch encapsulates pclose() and its attributes in an explicit specialization for std::default_delete<>, "hiding" the attributes inside a functor. The particular solution was inspired by Anton-V-K's proposal in https://gist.github.com/t-mat/5849549 This commit builds on an earlier patch for the same purpose by Michael Smith: https://gerrit.cloudera.org/c/23058/ Change-Id: Ia4454b0c359dbf579e6ba2f9f9c44cfa3f1de0d2 Reviewed-on: http://gerrit.cloudera.org:8080/23384 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> --- M be/src/util/webserver-test.cc M bin/bootstrap_build.sh M bin/bootstrap_system.sh M bin/bootstrap_toolchain.py M bin/impala-config.sh 5 files changed, 39 insertions(+), 15 deletions(-) Approvals: Impala Public Jenkins: Verified Michael Smith: Looks good to me, but someone else must approve Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia4454b0c359dbf579e6ba2f9f9c44cfa3f1de0d2 Gerrit-Change-Number: 23384 Gerrit-PatchSet: 10 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
