Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23422 )
Change subject: IMPALA-14433: Fix OpenTelemetry Tracing Deadlock ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23422/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/23422/1/be/src/service/impala-server.cc@1428 PS1, Line 1428: (*query_handle)->otel_span_manager()->EndChildSpanPlanning(); > It would not. There are places where child_span_mu_ is locked without also I was wondering if we could switch the order everywhere. We wouldn't always need to take the ClientRequestState lock, just never take it after child_span_mu_. -- To view, visit http://gerrit.cloudera.org:8080/23422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b43dba794cfe61d283bdd476e4056b9304d8947 Gerrit-Change-Number: 23422 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 15 Sep 2025 21:06:21 +0000 Gerrit-HasComments: Yes
