Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23383 )
Change subject: IMPALA-14295: [WIP] Support table masking for the Calcite planner ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23383/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java: http://gerrit.cloudera.org:8080/#/c/23383/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@293 PS4, Line 293: SqlNode validatedMaskedNode = createMaskedNode(dbName, tblName, columns); I have verified that if we change this statement to the following, then the issue as described in the commit message of patch set 4 could be fixed. That is, we provide all the columns in the table 'validatorTable' instead of 'columns', the selected columns in the table. This however, seems a bit hacky, and this would also register the privilege requests for all the columns in 'validatorTable' (v.s. only the selected columns). SqlNode validatedMaskedNode = createMaskedNode(dbName, tblName, ((CalciteTable) validatorTable).getColumns()); -- To view, visit http://gerrit.cloudera.org:8080/23383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d9cf028078762f78cf0f82b817bdc1ee37e180b Gerrit-Change-Number: 23383 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 15 Sep 2025 22:50:25 +0000 Gerrit-HasComments: Yes
