Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )
Change subject: IMPALA-14446: Clean up pom.xml ...................................................................... Patch Set 7: > Patch Set 7: > > > Patch Set 7: > > > > (1 comment) > > Thank you for checking those. I am slightly concerned about the > commons-dbcp2 version downgrade. Per the release notes at > https://commons.apache.org/proper/commons-dbcp/changes-report.html, there are > no major changes between 2.9.0 and 2.12, but there are a lot of bug fixes. > Would you be ok with bumping the IMPALA_DBCP2_VERSION env var from 2.9.0 to > 2.12? My concern is introducing difficult to debug issues because a bug fix > is now gone from commons-dbcp. I know it's not a pom fix, thus tackling it > in another change works too. That changes makes sense, I'll upgrade it. -- To view, visit http://gerrit.cloudera.org:8080/23432 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0 Gerrit-Change-Number: 23432 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 19 Sep 2025 15:59:06 +0000 Gerrit-HasComments: No
