Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 )
Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@35 PS3, Line 35: * (filesystem, HMS, etc with no caching. nit: ")" http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java: http://gerrit.cloudera.org:8080/#/c/10627/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java@30 PS3, Line 30: into LocalCatalog Is it required/intended to be so specific? Nothing here restricts which process reads metadata or what it does with it. This looks more like a federation api. I'd just replace the last two words with a "see LocalCatalog for an example". -- To view, visit http://gerrit.cloudera.org:8080/10627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab653371188b21c72f50ee1ec4e94950aa6fb9ee Gerrit-Change-Number: 10627 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Jun 2018 20:43:54 +0000 Gerrit-HasComments: Yes
