Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22997 )
Change subject: IMPALA-13801: Support greatest synced event with hierarchical metastore event processing ...................................................................... Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/22997/21/fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java File fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java: http://gerrit.cloudera.org:8080/#/c/22997/21/fe/src/main/java/org/apache/impala/catalog/events/EventExecutorService.java@547 PS21, Line 547: Long nextUnprocessedEventId = inProgressLog_.higherKey(greatestSyncedEventId); What about keys in inProgressLog_ that are lower than processedLog_.firstKey()? I think the algorithm assums that processedLog_.firstKey() <= inProgressLog_.firstKey() when inProgressLog_ is not empty. So there are no such keys. But it seems wrong for the following sequence: * At the begining (e.g. after startup or global IM), both maps are empty. * Keys are added into inProgressLog_, e.g. [1, 2, 3, 4]. * One key after the first one is processed and moved to the processedLog_, e.g. [3]. Then there are still some event ids [1,2] in inProgressLog_ and are smaller than processedLog_.firstKey() (3). -- To view, visit http://gerrit.cloudera.org:8080/22997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26240f36aaf85125428dc39a66a2a1e4d3197e85 Gerrit-Change-Number: 22997 Gerrit-PatchSet: 21 Gerrit-Owner: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Sep 2025 07:48:55 +0000 Gerrit-HasComments: Yes
