Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23438 )
Change subject: IMPALA-14451: Log if memory-based admission is skipped ...................................................................... IMPALA-14451: Log if memory-based admission is skipped When admission control is enabled, but max memory for pool is not configured, Impala skips memory-based admission completely, i.e. it doesn't even take available host memory into account. This behavior can lead to admitting many queries with large memory consumption, potentially causing query failures due to memory exhaustion. Fixing the above behavior might cause regressions in some workloads, so this patch just adds a new log message which makes it clear why a query gets admitted, and also mentions possible failures. Change-Id: Ib98482abc0fbcb53552adfd89cf6d157b17527fd Reviewed-on: http://gerrit.cloudera.org:8080/23438 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/scheduling/admission-controller.cc 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib98482abc0fbcb53552adfd89cf6d157b17527fd Gerrit-Change-Number: 23438 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
